Skip to content

remove now-unused rubocop-packs dependency#106

Merged
technicalpickles merged 4 commits intomainfrom
rubocop-packs-dependency
Sep 20, 2023
Merged

remove now-unused rubocop-packs dependency#106
technicalpickles merged 4 commits intomainfrom
rubocop-packs-dependency

Conversation

@technicalpickles
Copy link
Copy Markdown
Contributor

Testing this theory: #105

@technicalpickles
Copy link
Copy Markdown
Contributor Author

This passes, so maybe a downstream use of it needs this around 🤔

@alexevanczuk
Copy link
Copy Markdown
Contributor

We don't need rubocop-packs here ever since e70fde7, but I forgot to remove it then! Could you also remove the RBI and the dependency listed in the gemspec?

@technicalpickles
Copy link
Copy Markdown
Contributor Author

@alexevanczuk done!

@mbutsko
Copy link
Copy Markdown

mbutsko commented Sep 18, 2023

Any update here?

mbutsko pushed a commit to emporatitle/packs that referenced this pull request Sep 18, 2023
@technicalpickles technicalpickles marked this pull request as ready for review September 20, 2023 14:12
@technicalpickles technicalpickles enabled auto-merge (squash) September 20, 2023 14:15
@technicalpickles technicalpickles changed the title try removing require of rubocop-packs require now-unused rubocop-packs dependency Sep 20, 2023
@technicalpickles technicalpickles changed the title require now-unused rubocop-packs dependency remove now-unused rubocop-packs dependency Sep 20, 2023
@technicalpickles technicalpickles enabled auto-merge (squash) September 20, 2023 14:15
@technicalpickles technicalpickles merged commit 3fc9422 into main Sep 20, 2023
@technicalpickles technicalpickles deleted the rubocop-packs-dependency branch September 20, 2023 15:07
@alexevanczuk
Copy link
Copy Markdown
Contributor

Thanks @technicalpickles ! If you would bump the version and merge that it'll auto release in case users want to pick it up. We're still working on my authentication to the rubyatscale repo so I can't do that yet.

@technicalpickles
Copy link
Copy Markdown
Contributor Author

done! #113

@Dukesiver
Copy link
Copy Markdown

thanks guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants