Restrict GITHUB_TOKEN permissions in CI workflow#38
Merged
Conversation
Resolves CodeQL alert actions/missing-workflow-permissions: the shared-config CI workflow only checks out code (with persist-credentials: false) and posts to a Slack webhook, neither of which needs write access, so contents: read is sufficient.
This was referenced Jul 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/missing-workflow-permissions): thecall-workflow-from-shared-configjob inci.ymlhad no explicitpermissionsblock, so it defaulted to the repository's token permissions.permissions: contents: readon the job. The called reusable workflow (rubyatscale/shared-config/.github/workflows/ci.yml) only checks out code (withpersist-credentials: false) and posts failure notifications via a Slack webhook secret — neither needs write access toGITHUB_TOKEN.Test plan
CIworkflow still passes (tests, type check, lint) after mergeCodeQLrun againstmain