Fix calendar issue and add admin-authored short description for "Add to calendar" links#1876
Merged
Conversation
Calendar entries (ICS DESCRIPTION is plain text per RFC 5545; the URL-based providers render HTML inconsistently at best) were getting an auto-flattened dump of the full rich show-page description. Give admins a dedicated plain-text blurb instead, falling back to the flattened rhino_description when blank so existing events are unaffected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
commented
Jun 22, 2026
| event_description = object.rhino_description.to_plain_text | ||
| # Prefer the admin-authored, calendar-specific blurb; fall back to a | ||
| # flattened version of the rich show-page description when it's blank. | ||
| event_description = object.calendar_description.presence || object.rhino_description.to_plain_text |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: .presence is the fallback hinge — blank calendar_description (nil or empty) falls back to the flattened rich description, so every pre-existing event keeps its current calendar text unchanged.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
changed the title
maebeale
marked this pull request as ready for review
June 22, 2026 15:56
maebeale
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR, suggested 👤 review level: 📖 Read — light-logic: small, contained logic changes with low blast radius
Calendar "Add to calendar" links were feeding the full rich show-page description (
rhino_description) into each calendar entry, flattened with.to_plain_text. Calendars don't render that markup — ICSDESCRIPTIONis plain text per RFC 5545, and the Google/Outlook/Yahoo URL params render HTML inconsistently — so admins had no real control over the calendar blurb.Why: give admins a dedicated, plain-text short description, while keeping existing events unaffected.
events.short_descriptiontext column.rhino_descriptionwhen blank.EventPolicy.