Add metadata/Stripe-charge-id search and amount range to payments index - #2210
Merged
Conversation
maebeale
marked this pull request as ready for review
August 15, 2026 14:05
The payments index only filtered by type, payer, and remaining-amount, so there was no way to locate a payment by its metadata contents, its Stripe charge id, or by size. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The payments amount range fields were the only number inputs in a collection filter form, so they never auto-submitted. Teach the shared controller to debounce-submit (and clear) number inputs like text inputs, so the amount range applies live and the explicit Search button is no longer needed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/payments-search-amount-filter
branch
from
August 15, 2026 14:31
ef672b6 to
ba7ce31
Compare
Grey the plain selects' default 'All' option (like the events/allocations filter selects) and put every field on the shared field_class/label_class so placeholders read consistently with the remote search boxes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
added a commit
that referenced
this pull request
Aug 16, 2026
CE attendance tracking (#2075), CE/licenses browse indexes (#2208), payments Stripe/metadata/amount search (#2210), grant sector+category tagging (#2199), richer communications log (#2177), and topic-subscription recipient filter (#2179). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 small filter additions to one model + one filter partial, covered by model specs
What is the goal of this PR and why is this important?
How did you approach the change?
Payment.search_by_paramswith asearchfilter (CAST(metadata AS CHAR) LIKE ? OR stripe_charge_id LIKE ?, wildcard-escaped) andamount_min/amount_maxdollar→cents range filters — all no-ops when blank, so an empty form returns every row.collectionStimulus controller andpayments_resultsturbo frame.Anything else to add?
metadatais a MySQL JSON column, so search is a substring match over the serialized JSON, not key-scoped.