Skip to content

Fix case contact reports downloading - #1047

Merged
compwron merged 4 commits into
masterfrom
1039-case-contact-reports
Oct 12, 2020
Merged

Fix case contact reports downloading#1047
compwron merged 4 commits into
masterfrom
1039-case-contact-reports

Conversation

@littleforest

Copy link
Copy Markdown
Collaborator

What github issue is this PR for, if any?

Resolves #1039

What changed, and why?

  • Added csv format to case contacts report url
  • Added restrictions in case_contact_reports controller to not allow volunteers
  • Fixed case contact report request spec to test that volunteers cannot access route but supervisors and admins are allowed
  • Modified Report controller to use Pundit authorization to be consistent with view

How will this affect user permissions?

  • Volunteer permissions: volunteers no longer allowed to access the /case_contacts_report url
  • Supervisor permissions: n/a
  • Admin permissions: n/a

How is this tested? (please write tests!) 💖💪

  • Fixed up request specs, added system test

Screenshots please :)

Screen Shot 2020-10-11 at 8 23 30 PM

@github-actions github-actions Bot added ruby Touches Ruby code Tests! 🎉💖👏 labels Oct 12, 2020

@compwron compwron left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖🎉✨✨

@compwron
compwron merged commit d7fd226 into master Oct 12, 2020
@compwron
compwron deleted the 1039-case-contact-reports branch October 12, 2020 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Touches Ruby code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate Report is broken

2 participants