Skip to content

Three more DRY spec refactors (casa_cases_spec.rb, reports_spec.rb, new_spec.rb)#6898

Merged
compwron merged 1 commit intorubyforgood:mainfrom
alanparmenter:refactor
May 3, 2026
Merged

Three more DRY spec refactors (casa_cases_spec.rb, reports_spec.rb, new_spec.rb)#6898
compwron merged 1 commit intorubyforgood:mainfrom
alanparmenter:refactor

Conversation

@alanparmenter
Copy link
Copy Markdown
Contributor

shared_examples for volunteer, supervisor and admin user roles

What github issue is this PR for, if any?

Relates to #6874

What changed, and why?

shared_examples added because these specs (casa_cases_spec.rb, reports_spec.rb, new_spec.rb) have repeated examples.

How is this tested? (please write rspec and jest tests!) 💖💪

bundle exec rspec spec/requests/casa_cases_spec.rb
bundle exec rspec spec/requests/reports_spec.rb
bundle exec rspec spec/system/supervisors/new_spec.rb

Feelings gif (optional)

Cactus staying DRY

shared_examples for volunteer, supervisor and admin user roles
@github-actions github-actions Bot added ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels May 1, 2026
@compwron compwron merged commit c4cb6cc into rubyforgood:main May 3, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Pull requests that update Ruby code Tests! 🎉💖👏

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants