Three more DRY spec refactors (casa_cases_spec.rb, reports_spec.rb, new_spec.rb)

spec/requests/casa_cases_spec.rb

@@ -1,5 +1,21 @@
 require "rails_helper"
 
+RSpec.shared_examples "casa_case access control" do |user_role|
+  it "renders a successful response" do
+    get casa_case_url(casa_case)
+    expect(response).to be_successful
+  end
+
+  it "fails across organizations" do
+    other_org = build(:casa_org)
+    other_case = create(:casa_case, casa_org: other_org)
+
+    get casa_case_url(other_case)
+    expect(response).to be_redirect
+    expect(flash[:notice]).to eq("Sorry, you are not authorized to perform this action.")
+  end
+end
+
 RSpec.describe "/casa_cases", type: :request do
   let(:date_in_care) { Date.today }
   let(:organization) { build(:casa_org) }
@@ -514,19 +530,7 @@
     let!(:case_assignment) { create(:case_assignment, volunteer: user, casa_case: casa_case) }
 
     describe "GET /show" do
-      it "renders a successful response" do
-        get casa_case_url(casa_case)
-        expect(response).to be_successful
-      end
-
-      it "fails across organizations" do
-        other_org = build(:casa_org)
-        other_case = create(:casa_case, casa_org: other_org)
-
-        get casa_case_url(other_case)
-        expect(response).to be_redirect
-        expect(flash[:notice]).to eq("Sorry, you are not authorized to perform this action.")
-      end
+      include_examples "casa_case access control"
     end
 
     describe "GET /new" do
@@ -652,19 +656,7 @@
     let(:user) { create(:supervisor, casa_org: organization) }
 
     describe "GET /show" do
-      it "renders a successful response" do
-        get casa_case_url(casa_case)
-        expect(response).to be_successful
-      end
-
-      it "fails across organizations" do
-        other_org = build(:casa_org)
-        other_case = create(:casa_case, casa_org: other_org)
-
-        get casa_case_url(other_case)
-        expect(response).to be_redirect
-        expect(flash[:notice]).to eq("Sorry, you are not authorized to perform this action.")
-      end
+      include_examples "casa_case access control"
     end
 
     describe "GET /new" do

spec/requests/reports_spec.rb

@@ -1,5 +1,13 @@
 require "rails_helper"
 
+RSpec.shared_examples "successful authentication" do |user_role|
+  before do
+    sign_in build(user_role)
+  end
+
+  it { is_expected.to be_successful }
+end
+
 RSpec.describe "/reports", type: :request do
   describe "GET #index" do
     subject do
@@ -8,19 +16,11 @@
     end
 
     context "while signed in as an admin" do
-      before do
-        sign_in build(:casa_admin)
-      end
-
-      it { is_expected.to be_successful }
+      include_examples "successful authentication", :casa_admin
     end
 
     context "while signed in as a supervisor" do
-      before do
-        sign_in build(:supervisor)
-      end
-
-      it { is_expected.to be_successful }
+      include_examples "successful authentication", :supervisor
     end
 
     context "while signed in as a volunteer" do

spec/system/supervisors/new_spec.rb

@@ -2,6 +2,18 @@
 
 require "rails_helper"
 
+RSpec.shared_examples "user redirect with error" do |user_role|
+  let(:user) { create(user_role) }
+
+  before { sign_in user }
+
+  it "redirects the user with an error message" do
+    visit new_supervisor_path
+
+    expect(page).to have_selector(".alert", text: "Sorry, you are not authorized to perform this action.")
+  end
+end
+
 RSpec.describe "supervisors/new", type: :system do
   context "when logged in as an admin" do
     let(:admin) { create(:casa_admin) }
@@ -80,26 +92,10 @@
   end
 
   context "when logged in as a supervisor" do
-    let(:supervisor) { create(:supervisor) }
-
-    before { sign_in supervisor }
-
-    it "redirects the user with an error message" do
-      visit new_supervisor_path
-
-      expect(page).to have_selector(".alert", text: "Sorry, you are not authorized to perform this action.")
-    end
+    include_examples "user redirect with error", :supervisor
   end
 
   context "when logged in as a volunteer" do
-    let(:volunteer) { create(:volunteer) }
-
-    before { sign_in volunteer }
-
-    it "redirects the user with an error message" do
-      visit new_supervisor_path
-
-      expect(page).to have_selector(".alert", text: "Sorry, you are not authorized to perform this action.")
-    end
+    include_examples "user redirect with error", :volunteer
   end
 end