feat(precommit): make mix precommit the canonical repository quality gate - #225
Merged
Merged
Conversation
bougyman
approved these changes
Sep 5, 2026
3 tasks
bougyman
approved these changes
Sep 5, 2026
- Insert root `mix format --check-formatted` and `mix test` (steps 3-4) between the metadata guards and the app checks in mix precommit. These cover the root project's own sources and validator tests. - Update the moduledoc to list all 11 steps with correct numbering. - Convert mix ci into a thin alias that delegates entirely to Mix.Tasks.Precommit (both run/1 and the testable run/2 passthrough). - Update precommit_test to assert all 11 steps in order. - Replace ci_test's independent step list with delegation assertions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- .ai/prompts/implement.md: replace `mix ci` with `mix precommit` in the quality-suite step. - Readme.adoc: present `mix precommit` as the canonical full-repository quality command; retain focused single-project commands below it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ruby-automation
force-pushed
the
EXT-31-precommit-canonical-quality-gate
branch
from
September 5, 2026 03:31
91b8f6f to
f137ec6
Compare
ruby-automation
enabled auto-merge (squash)
September 5, 2026 03:31
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mix precommitby inserting rootmix format --check-formattedandmix test(steps 3–4) between the metadata guards and the app checks. These ensure the root project's own sources and validator/task tests are covered by the gate.mix ciinto a thin alias that fully delegates toMix.Tasks.Precommit(bothrun/1for production andrun/2for testability).precommit_test.exsto assert all 11 steps in sequence.ci_test.exs's independent 7-step list with delegation assertions (also adds the previously missingdeps.auditandcredo --strictcoverage)..ai/prompts/implement.mdandReadme.adocto presentmix precommitas the canonical quality command.Depends on
Out of scope
.github/workflows/ci.yaml— the workflow still callsmix ci, which now aliases tomix precommit. Workflow updates are EXT-32's scope.Test plan
mix testat repo root: 42 passed (2 new ci_test cases replacing old 1)mix format --check-formattedat repo root: cleanprecommit_test.exsvia injected shellci_test.exsverifies full 11-step delegation and argument rejectionCloses EXT-31
🤖 Generated with Claude Code