ci: enforce PR title and commit subjects in GitHub Actions (EXT-32) - #234
Merged
Conversation
- ci.yaml: add 'edited' to pull_request trigger types; replace
skip_commit_validation boolean with granular base_ref,
pull_request_title_required, and pull_request_title workflow_call
inputs; Test job now runs mix precommit (full 11-step gate) with
fetch-depth 0 and real PR head SHA; BASE_REF/PULL_REQUEST_TITLE*
passed via env: block (never ${{ }} in run:); burrito_changes excludes
edited events; conventional_commits compatibility job retained with
corrected condition for EXT-33 migration
- main.yaml: pass granular inputs instead of skip_commit_validation:true;
base_ref carries github.event.before for push events and
pull_request.base.sha for closed-PR events
- ci/validate_commit_range.sh: simplify git log format from
'%P%x01%cn%x01%ce%x01%s' to '%s'; remove unused parents/committer
parsing left behind when the merge-commit exemption was removed
- test/git_hooks_test.exs: clear CI env vars (BASE_REF,
PULL_REQUEST_TITLE*) from run/3 subprocess calls via env(1) -u so
GitHub Actions job environment does not corrupt local test results
- test/mix/tasks/precommit_test.exs: use assert_received (synchronous)
instead of assert_receive for consistency with ci_test.exs
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the EXT-32 GitHub Actions event contract from Phase 14. This is a clean re-cut from current
main(after EXT-31 merged as #225), so the diff is exactly the 5 EXT-32-specific files with no spurious deletions..github/workflows/ci.yamleditedto thepull_requesttrigger so title-only changes retriggerTestwithout a new commitskip_commit_validationboolean with three granularworkflow_callinputs:base_ref,pull_request_title_required,pull_request_titleTestjob now runsmix precommit(full 11-step gate) withfetch-depth: 0and real PR head SHA (github.event.pull_request.head.sha || github.sha)BASE_REF,PULL_REQUEST_TITLE_REQUIRED, andPULL_REQUEST_TITLEexported viaenv:— never inrun:— so titles with quotes/backticks/dollar signs/Unicode are inert databurrito_changesguard excludeseditedevents — title changes have no file diffconventional_commitscompatibility job retained with corrected condition for EXT-33 migration.github/workflows/main.yamlskip_commit_validation: truewith granular inputsbase_refcarriesgithub.event.beforefor push events andpull_request.base.shafor closed-PR eventsci/validate_commit_range.sh%s; removed unused parents/committer parsingtest/git_hooks_test.exsrun/3helper clears CI env vars viaenv(1) -uso GitHub Actions job environment does not corrupt local test resultstest/mix/tasks/precommit_test.exsassert_receivetoassert_receivedfor consistency withci_test.exsTest plan
Testjob log showsmix precommitrunning withBASE_REFandPULL_REQUEST_TITLEsetValidate Commit Subjectscompatibility job still runs and passesCloses: https://linear.app/the-rubyists/issue/EXT-32
🤖 Generated with Claude Code