fix: pass GH_TOKEN to deploy-shared.yml's deploy step - #141
Merged
Conversation
deploy/deploy.py resolves and downloads release refs via the gh CLI (deploy/resolve.py), which needs GH_TOKEN/GITHUB_TOKEN in its environment. Every other job that shells out to gh (upload-apps, encrypt) already passes a token explicitly to its action; the deploy step never did, so every real deploy failed at ref resolution: "Could not resolve GitHub latest release ... set the GH_TOKEN environment variable." Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Aug 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First real deploy attempt (to heimdall, triggered by the v0.6.0 release push) failed at ref resolution:
deploy/deploy.pyshells out to theghCLI (viadeploy/resolve.py) to resolve@latestand download release assets. Every other job that needsgh(upload-apps,encrypt) already passes a token explicitly to its action; thedeploystep indeploy-shared.ymlnever did. Fixed by addingGH_TOKEN: ${{ secrets.GITHUB_TOKEN }}to that step's env, alongside the existingSOPS_AGE_KEY.Test plan