Set correct script attributes in AbstractSimpleAggregation - #748
Merged
Conversation
Existing code would not set 'lang' (making it impossible to e.g. use groovy in those scripts) It would also always add 'params', even if there aren't any
I had blindly set params, overriding any existing params. Now they'll be merged properly: only the params known to $script will be overriden. Unrelated existing additional parameters will remain intact.
Owner
|
Can you add a small test to make sure this problem does not occur again? |
MediaWiki has spaces around parentheses & my IDE auto-formats source like that. Obviously, don't want this here.
My change slightly dropped code coverage: when passing a Script, it used to manually extract the script (as string) from the Script object & set it. Now that I've changed it to use Script::toArray(), that "set script as string" patch was no longer being tested. This adds a separate test for that case.
ruflin
added a commit
that referenced
this pull request
Jan 14, 2015
Set correct script attributes in AbstractSimpleAggregation
Owner
|
Thx, merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing code would not set 'lang' (making it impossible to e.g. use groovy in those scripts)
It would also always add 'params', even if there aren't any