docs(lore-0124): complete + archive — spec routed via PR #169 - #175
Merged
Conversation
PR #169 merged to develop (squash dabdd15) after okarcz's approval, three CI jobs green. Shipped: GET /api-docs-json as a keyless cached proxy route, `servers` stamped from apiBaseUrl, ErrorEnvelope published, a Redocly recommended-strict gate, and three artifact-derived guards. Converted to a directory as the task's own Future Work planned — deferred to archive time so the reviewer never saw a large rename mid-review. The three heavy sections moved to notes/S-*, leaving a ~420-line README. Two ACs stay deployment-verified rather than verified: the live /api-docs-json fetch and the advertised `servers` URL serving a route both need `make -C infra deploy-production`. docs/scf/api-endpoints.md carries the curl. Also quoted the history dates, which failed lore frontmatter validation as bare YAML date scalars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lore bookkeeping only — no source, infra or CI changes. The implementation
shipped in #169 (squash
dabdd15).What this does
active/→archive/, converting it to a directory. Gittracks it as a rename (59% similarity).
notes/S-*— the validator result, thefeat(0124): expose the OpenAPI spec through API Gateway #169 review response, and the self-review round. README drops ~680 → ~420
lines, in line with 0088 and 0044.
status: completedand adds thedonehistory entry naming the squash.history[].datevalues. They were bare YAML date scalars andfailed
lore_validatewith 5 errors; it now passes clean.The directory conversion is not a drive-by — it is what this task's own Future
Work section planned, deliberately deferred to archive time so the reviewer
never saw a large rename on the file he was reading.
Inbound
[[0124]]references from 0117, 0119, 0120, 0126, 0128 and 0155 resolveby ID, so none needed touching.
lore/README.mdandnext-tasks.mdwereregenerated but are gitignored in this repo, so they are absent from the diff.
Carried forward, for the record
Two acceptance criteria are marked
[x]as deployment-verified rather thanverified — the live
GET …/production/api-docs-jsonfetch and confirming theadvertised
serversURL serves a route. Both needmake -C infra deploy-production;docs/scf/api-endpoints.mdcarries the curl.Design decision 8 (
info.licenseleft empty) is flagged for @adamkoot and isspawned as 0155.