Fixed bug: Icon disposed

[Kyome22]

Context of Contribution

• Bug Fix
• Refactoring
• New Feature
• Others

Summary of the Proposal

#236

Checklist

• This PR does not contain commits of multiple contexts.
• Code follows proper indentation and naming conventions.
• Works correctly in both dark theme and light theme.
• Works correctly on any device.

[Kyome22]

I haven't been able to reproduce the actual issue locally, so I can't be certain if this has fixed the issue.

@mor39a Do you have any ideas on how to reproduce the issue?

[mor39a]

@mor39a Do you have any ideas on how to reproduce the issue?

I never had this bug, so I have no idea how to reproduce it. However, I will check it out.

[mor39a]

Hi @Kyome22, what version of Windows are you using? I did some research, but I wasn't able to replicate it (I'm using Windows 10). Issues #236 and #233 reported using Windows 11 24H2. It's possible that the different way updates are handled means we can't replicate the error.

Since neither of us has been able to replicate the bug, I suggest asking the issue #236 reporter to test it whenever we make progress. It might be a bit tedious, but I can't think of any other solution.

---

Although I'm not really sure, I suspect that the notifyIcon object has been disposed for some reason, leaving the notifyIcon.Icon object inaccessible. Adding a conditional on lines 257 and 270 of ContextMenuManager.cs, that checks if notifyIcon is disposed, I hope that fixes the problem.

https://github.com/Kyome22/RunCat365/blob/02c7ac261ffae9ca41b680a5d6738a1bc705201b/RunCat365/ContextMenuManager.cs#L255-L258

https://github.com/Kyome22/RunCat365/blob/02c7ac261ffae9ca41b680a5d6738a1bc705201b/RunCat365/ContextMenuManager.cs#L270

---

I will continue investigating and keep you posted.

[AndreaVielCGN]

Where is this defined? Icon doesn't have this property and doesn't compile

[muko]

I was able to reproduce this issue while debugging commit fdf0100 on the main branch, so I'm reporting it here.
My environment: Windows 11 24H2 (26100.6584).
It seems to happen more often after the PC wakes up from sleep.

System.ObjectDisposedException
HResult=0x80131622
Message=Cannot access a disposed object.
Object name: 'Icon'.
Source=System.Windows.Forms
StackTrace:
at System.Windows.Forms.NotifyIcon.UpdateIcon(Boolean showIconInTray)
at RunCat365.ContextMenuManager.SetNotifyIconText(String text) in C:\Projects\RunCat\RunCat365\ContextMenuManager.cs:line 267
at RunCat365.RunCat365ApplicationContext.FetchSystemInfo(CPUInfo cpuInfo, MemoryInfo memoryInfo, List`1 storageValue) in C:\Projects\RunCat\RunCat365\Program.cs:line 183
at RunCat365.RunCat365ApplicationContext.FetchTick(Object state, EventArgs e) in C:\Projects\RunCat\RunCat365\Program.cs:line 209
at System.Windows.Forms.NativeWindow.Callback(HWND hWnd, MessageId msg, WPARAM wparam, LPARAM lparam)