Skip to content

Add network speed display#242

Merged
Kyome22 merged 5 commits into
runcat-dev:mainfrom
ladeng07:network
Nov 30, 2025
Merged

Add network speed display#242
Kyome22 merged 5 commits into
runcat-dev:mainfrom
ladeng07:network

Conversation

@ladeng07
Copy link
Copy Markdown

@ladeng07 ladeng07 commented Sep 10, 2025

Context of Contribution

  • Bug Fix
  • Refactoring
  • New Feature
  • Others

Reason for the new feature

Hello, I've been using RunCat for four years. I've added a network speed display feature that shows up when you hover the mouse over the system tray icon. This is incredibly helpful for me to check my real-time network speed while watching videos or during downloads/uploads, eliminating the need to install additional software just to monitor my internet speed.
image
4e281f68a008fd8dc491a555ed9d1d06

Checklist

  • This PR does not contain commits of multiple contexts.
  • Code follows proper indentation and naming conventions.
  • Works correctly in both dark theme and light theme.
  • Works correctly on any device.

Comment thread RunCat365/ContextMenuManager.cs
Comment thread RunCat365/NetworkRepository.cs Outdated
Comment thread RunCat365/NetworkRepository.cs Outdated
Comment thread RunCat365/NetworkRepository.cs
Comment thread RunCat365/Program.cs Outdated
Comment thread RunCat365/Program.cs Outdated
Comment thread RunCat365/Program.cs Outdated
Comment thread RunCat365/Program.cs Outdated
@mor39a
Copy link
Copy Markdown
Collaborator

mor39a commented Sep 12, 2025

Hi @ladeng07, reviewing your fork, it appears that instead of using the main branch as a base, you're using the fix-bug-icon-disposed branch. This makes it seem like you were trying to address issues related to PR #241.

@ladeng07
Copy link
Copy Markdown
Author

Hi @ladeng07, reviewing your fork, it appears that instead of using the main branch as a base, you're using the fix-bug-icon-disposed branch. This makes it seem like you were trying to address issues related to PR #241.

Sorry, I started from the wrong branch. I will fix it.

@Kyome22
Copy link
Copy Markdown
Collaborator

Kyome22 commented Nov 17, 2025

@ladeng07 Has the revision been completed?
If possible, please indicate whether it has been addressed by replying to each of my review comments.
Generally, one review is addressed with one commit.

@ladeng07
Copy link
Copy Markdown
Author

@ladeng07 Has the revision been completed? If possible, please indicate whether it has been addressed by replying to each of my review comments. Generally, one review is addressed with one commit.

@Kyome22 I apologize for my lack of proficiency, but I believe I have completed the revision work.

Comment thread RunCat365/Program.cs Outdated
Comment thread RunCat365/NetworkRepository.cs Outdated
Copy link
Copy Markdown
Collaborator

@Kyome22 Kyome22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring is needed, but I've determined that it's mergeable.

@Kyome22 Kyome22 merged commit 33d06e8 into runcat-dev:main Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants