Merged
Conversation
Contributor
ltamaster
commented
Apr 25, 2019
ltamaster
commented
- Adding option plugin generator (java and script plugin)
- Changing the template of build.gradle of java plugins in order to use external dependencies
- Using the picocli library (https://picocli.info/) for the client (mainly to improve the help on the command line)
- Changing template of build.gradle of java plugins in order to use external dependencies - Using a picocli for the client (mainly to improve the help on the command line)
sjrd218
suggested changes
Apr 25, 2019
Contributor
sjrd218
left a comment
sjrd218
left a comment
There was a problem hiding this comment.
Looks really good Luis. Just small changes.
I think we need to make sure the source link attribute has the template text I mentioned in one of the comments applied to all plugins, just to make sure we're not sending people to the wrong source repo.
Excellent work. Really excited about this upgrade.
- minimum rundeck version should be 3.0.14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.