Skip to content

Expand netherworld challenge ROI#1640

Closed
leovefy wants to merge 1 commit into
runhey:devfrom
leovefy:codex/cobra-02-netherworld-roi
Closed

Expand netherworld challenge ROI#1640
leovefy wants to merge 1 commit into
runhey:devfrom
leovefy:codex/cobra-02-netherworld-roi

Conversation

@leovefy

@leovefy leovefy commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Split from leovefy/cobra.

This PR contains a single commit: 95d0c81.
Base: runhey/dev.

Summary by Sourcery

调整冥界狩猎挑战检测参数,并记录推荐的单任务调试与测试工作流程。

Bug Fixes:

  • 通过扩展图像匹配的 ROI(感兴趣区域),提升冥界挑战按钮的识别效果。

Documentation:

  • 新增 AGENT.md,描述在不运行完整调度器的情况下,隔离、修复并验证单个任务失败的具体流程。
Original summary in English

Summary by Sourcery

Adjust netherworld hunt challenge detection parameters and document the recommended single-task debugging and testing workflow.

Bug Fixes:

  • Improve the netherworld challenge button recognition by expanding its image matching ROI.

Documentation:

  • Add AGENT.md describing the process for isolating, fixing, and validating individual task failures without running the full scheduler.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - 我在这里提供了一些总体反馈:

  • 建议将标识符 I_NW_CHALLAGE 更正为 I_NW_CHALLENGE(并更新所有引用),以避免混淆并提升可读性。
  • I_NW_CHALLAGE 的 ROI 坐标是硬编码的;如果类似的数值在其他地方也被复用,考虑将它们集中到共享配置中,以减少重复并方便后续调整。
给 AI Agent 的提示
请处理本次代码评审中的所有评论:

## 总体评论
- 建议将标识符 `I_NW_CHALLAGE` 更正为 `I_NW_CHALLENGE`(并更新所有引用),以避免混淆并提升可读性。
- `I_NW_CHALLAGE` 的 ROI 坐标是硬编码的;如果类似的数值在其他地方也被复用,考虑将它们集中到共享配置中,以减少重复并方便后续调整。

Sourcery 对开源项目是免费的——如果你觉得我们的评审有帮助,欢迎分享 ✨
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续评审。
Original comment in English

Hey - I've left some high level feedback:

  • Consider correcting the I_NW_CHALLAGE identifier to I_NW_CHALLENGE (and updating any references) to avoid confusion and improve readability.
  • The ROI coordinates for I_NW_CHALLAGE are hard-coded; if similar values are reused elsewhere, it may be cleaner to centralize them in a shared configuration to reduce duplication and ease future adjustments.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider correcting the `I_NW_CHALLAGE` identifier to `I_NW_CHALLENGE` (and updating any references) to avoid confusion and improve readability.
- The ROI coordinates for `I_NW_CHALLAGE` are hard-coded; if similar values are reused elsewhere, it may be cleaner to centralize them in a shared configuration to reduce duplication and ease future adjustments.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@runhey

runhey commented Jun 25, 2026

Copy link
Copy Markdown
Owner

agent.md 不加,你可以写在本地的 .agent文件夹里面 按理说这个写在了.gitignore里面了呀,就奇怪

@runhey runhey closed this Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants