Remove dead code and unused imports#4
Merged
Merged
Conversation
Major features: - Audio recording with waveform visualization and playback - Voice transcription using WhisperKit and Apple Speech - Image validation and compression for CloudKit limits - Data migration system for version upgrades - Demo data generator for testing - New app icon and branding Improvements: - Empty state views for better UX - Safari in-app browser for links - Enhanced editor configuration UI - Expanded localization support (EN/CN) - Image validation for CloudKit 10MB limit Infrastructure: - Test suite foundation (NotableTests) - Migration manager for Core Data schema changes - Updated documentation (CLAUDE.md, README) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Cleanup identified by dead code analysis: - Remove unused textModelLoaded property from SharedData.swift (remnant from removed CLIPKit integration) - Remove commented-out model loading check in ContentView.swift - Remove unused Combine import from Persistence.swift Build verified successful after changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup identified from comprehensive dead code analysis:
• Remove unused textModelLoaded property from SharedData.swift
(remnant from removed CLIPKit integration)
• Remove commented-out model loading check in ContentView.swift
• Remove unused Combine import from Persistence.swift
Impact: 6 lines removed, zero functional changes, build verified.
All changes have been pushed to the cleanup/remove-dead-code branch and
are ready for review!