Negotiate cell execution start and resume#282
Conversation
76c7d67 to
9a41930
Compare
jlewi
changed the title
## Summary - add a first-message `OpenRunRequest` negotiation with explicit `START` and `RESUME` intent - return authoritative `CREATED` or `RUNNING` acknowledgements - reject duplicate starts with `ALREADY_EXISTS` and missing resumes with `NOT_FOUND` - preserve the existing create-or-attach behavior for legacy clients that do not negotiate - add runner coverage for start, resume, missing resume, duplicate start, and legacy behavior ## Why The previous WebSocket contract used an unknown `runID` for both a genuinely new execution and a reconnect to a forgotten execution. On reconnect, a completed or lost run could therefore create an empty multiplexer that answered heartbeats but never emitted an exit event, leaving the web UI stuck in a running state. Explicit intent removes that ambiguity without breaking older clients. This is intended for a runner-first rollout. Coordinated web change: runmedev/web#282 Design doc: https://github.com/runmedev/web/blob/codex/fix-stale-cell-execution/docs-dev/design/20260715_execution_monitoring.md ## Validation - `go test -timeout 120s ./pkg/agent/runme/stream` - `runme run lint` - targeted protobuf generation for `api/proto/runme/stream/v1/websockets.proto` `runme run test` was also attempted. It reaches unrelated environment-dependent failures in the existing suite because Dagger/Deno tooling is unavailable and the local shell startup prints a `z` upgrade notice. The changed stream package and all new negotiation tests pass. --------- Signed-off-by: Jeremy lewi <jeremy@lewi.us>
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
75e7c6e to
471fa6b
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 471fa6b31a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| negotiationComplete = true | ||
| this.nextIntent = RunIntent.RESUME |
There was a problem hiding this comment.
If the first socket drops after the runner creates the run but before the browser receives RUN_STATE_CREATED, nextIntent is still START; the reconnect sends START for the same runID, which the new protocol reports as ALREADY_EXISTS, and the status path then treats it as terminal instead of attaching. In that race the queued execute request is never released, leaving an empty/orphaned run and a cell that stays locally running without output; handle ALREADY_EXISTS after a START attempt by retrying with RESUME or otherwise making the start handshake idempotent.
Useful? React with 👍 / 👎.
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
1 participant
Summary
STARTorRESUMEintent as the first WebSocket application messagerunIDunknownonly when the runner returns authoritativeNOT_FOUNDRoot cause
The old runner could not distinguish a new execution from a reconnect. Connecting with an unknown historical
runIDcreated an empty multiplexer that answered heartbeats but had no process and would never emit an exit event. A persisted PID therefore left the cell displaying as running indefinitely.Behavior
runIDcontinues to identify the execution; each WebSocket gets a freshstreamID.START, expectCREATED.RESUME, expectRUNNING.NOT_FOUND, clear the stale PID, and recordunknown.Users may select another runner and rerun the cell, which creates a new
runIDand stops monitoring the old one. If the old runner remains unreachable, the client cannot guarantee that its process stopped. A future explicit abandon action can clear local running state without claiming remote cancellation.Completed terminal results are not retained in this version. If a run finishes while the browser is disconnected, reconnect returns
NOT_FOUND; retaining and replaying the exit result is documented as a future protocol extension.Coordinated runner change: runmedev/runme#1247
Design doc: https://github.com/runmedev/web/blob/codex/fix-stale-cell-execution/docs-dev/design/20260715_execution_monitoring.md
Validation
pnpm --filter @runmedev/renderers exec vitest run src/streams.test.tspnpm --filter @runmedev/app exec vitest run src/lib/notebookData.test.tsrunme run build test