fix: unpin runpod-flash to released 1.19.0 - #103
Merged
Conversation
The temporary git pin added in a44da63 (SLS-360) referenced branch deanquinanola/sls-360-local-module-bundling, which was deleted when runpod/flash#352 merged. Any uv lock/sync on main has failed since with "couldn't find remote ref", breaking the scheduled Bump Runtime Dependencies workflow. runpod-flash 1.19.0 is the first release containing runpod_flash.runtime.module_loader, so the pin can now be replaced with the released constraint the original comment called for. - pyproject.toml: git ref -> runpod-flash>=1.19.0 - uv.lock: runpod-flash 1.18.0 (git) -> 1.19.0 (registry) - uv.lock: runpod 1.10.2.dev1 (runpod-python git main) -> 1.10.1 (registry); the git source was pulled in transitively by the flash branch pin and is not intended
4 tasks
jhcipar
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The scheduled Bump Runtime Dependencies workflow has been failing since 2026-07-24 (latest run):
a44da63(SLS-360) pinnedrunpod-flashto a flash feature branch as an explicitly temporary measure, because the worker importsrunpod_flash.runtime.module_loaderwhich had no published release. That branch was deleted when runpod/flash#352 merged on 2026-07-20, leaving a dangling ref.This breaks any clean
uv lock/uv synconmain, not just the bump workflow.Fix
runpod-flash1.19.0 (released 2026-07-28, contains runpod/flash#352) is the first release shippingrunpod_flash/runtime/module_loader.py, so the pin is replaced with the released constraint the original TODO called for.pyproject.toml: git ref ->runpod-flash>=1.19.0uv.lock:runpod-flash1.18.0 (git) -> 1.19.0 (registry)uv.lock:runpod1.10.2.dev1 (runpod-pythongitmain) -> 1.10.1 (registry)Note on the
runpodchangeThe flash branch pin was transitively dragging in
runpodfromrunpod-pythongitmain(an unpinned moving target). Dropping the flash git dep drops that too, sorunpodnow resolves from PyPI. This is intended — the worker should not ship a dependency on another repo'smain— but it is a real change in what gets installed, and 1.10.1 is nominally lower than the1.10.2.dev1snapshot it replaces.It does not go to 1.11.0 (current PyPI latest) because
--upgrade-packageonly unpins the named package, and 1.11.0 requires newer pinnedboto3/fastapi/click, so uv backtracks. The lock was generated with the bump workflow's own command, so the next scheduled run produces no further diff.Test plan
uv lock --upgrade-package runpod-flash --upgrade-package runpod— the failing command — now succeedsmodule_loader.pyconfirmed present in the published 1.19.0 wheelfrom runpod_flash.runtime.module_loader import *imports against installed 1.19.0make quality-check: 283 passed, coverage 81.52% (threshold 35%), ruff + mypy cleanmake test-handler: 14/14 passedFollow-up
A CI guard rejecting
git+dependencies inpyproject.tomlonmainwould prevent recurrence — a branch pin both silently defeats the version-bumping workflow and hard-fails once the branch is deleted. Proposed as a separate PR.