Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated hf_models_to_cache parameter from the remote execution framework. The parameter was previously used to specify HuggingFace model IDs for pre-caching but is being deprecated in favor of a new caching mechanism.
Key changes:
- Removed
hf_models_to_cacheparameter from all function signatures - Updated test files to remove the deprecated parameter from test calls
- Cleaned up protocol buffer definitions and request structures
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/test_execute_class.py | Removed hf_models_to_cache parameter from all create_remote_class test calls |
| tests/unit/test_class_caching.py | Updated test calls to remove the deprecated parameter |
| tests/integration/test_class_execution_integration.py | Cleaned up integration tests by removing the parameter |
| src/tetra_rp/stubs/registry.py | Removed parameter from stub function signatures |
| src/tetra_rp/stubs/live_serverless.py | Removed parameter handling from serverless stub |
| src/tetra_rp/protos/remote_execution.py | Removed field definition from Pydantic model |
| src/tetra_rp/protos/remote_execution.proto | Removed field from protobuf definition |
| src/tetra_rp/execute_class.py | Removed parameter from create_remote_class function |
| src/tetra_rp/client.py | Removed parameter from remote decorator function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
pandyamarut
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.