Skip to content

refactor: deprecate hf_models_to_cache#95

Merged
deanq merged 1 commit intomainfrom
deanq/ae-1268-deprecate-hf_models_to_cache
Oct 8, 2025
Merged

refactor: deprecate hf_models_to_cache#95
deanq merged 1 commit intomainfrom
deanq/ae-1268-deprecate-hf_models_to_cache

Conversation

@deanq
Copy link
Member

@deanq deanq commented Oct 4, 2025

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated hf_models_to_cache parameter from the remote execution framework. The parameter was previously used to specify HuggingFace model IDs for pre-caching but is being deprecated in favor of a new caching mechanism.

Key changes:

  • Removed hf_models_to_cache parameter from all function signatures
  • Updated test files to remove the deprecated parameter from test calls
  • Cleaned up protocol buffer definitions and request structures

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/unit/test_execute_class.py Removed hf_models_to_cache parameter from all create_remote_class test calls
tests/unit/test_class_caching.py Updated test calls to remove the deprecated parameter
tests/integration/test_class_execution_integration.py Cleaned up integration tests by removing the parameter
src/tetra_rp/stubs/registry.py Removed parameter from stub function signatures
src/tetra_rp/stubs/live_serverless.py Removed parameter handling from serverless stub
src/tetra_rp/protos/remote_execution.py Removed field definition from Pydantic model
src/tetra_rp/protos/remote_execution.proto Removed field from protobuf definition
src/tetra_rp/execute_class.py Removed parameter from create_remote_class function
src/tetra_rp/client.py Removed parameter from remote decorator function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@deanq deanq marked this pull request as ready for review October 6, 2025 16:13
@deanq deanq merged commit 963bfd7 into main Oct 8, 2025
7 checks passed
@deanq deanq deleted the deanq/ae-1268-deprecate-hf_models_to_cache branch October 8, 2025 05:44
@deanq deanq mentioned this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants