fix: preserve empty dict handler output#532
Open
chenlichao wants to merge 1 commit into
Open
Conversation
|
Capy auto-review is paused for this organization because the usage-cycle auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{}returned by serverless handlers as a validoutputpayload.run_job()and the localrunsyncsimulation path.Why this helps
KeyErrorexception within framework #459, where a handler returning an empty dict caused_sim_runsync()to raiseKeyError: 'output'while building the completed response.Test Plan
pytest tests/test_serverless/test_modules/test_job.py::TestJob::test_run_job_preserves_empty_dict_output tests/test_serverless/test_modules/test_fastapi.py::TestFastAPI::test_runsync -q --no-covgit diff --checkNote: the same targeted pytest command without
--no-covran both tests successfully, but the repository-wide coverage gate failed because only two focused tests were selected.