fix: Remove hardcoded test version from makefile#205
Merged
DeJayDev merged 3 commits intorunpod:mainfrom Nov 18, 2025
Merged
Conversation
The makefile 'version' target was writing "1.0.0-test" to a file called "VERSION" (uppercase), which caused issues on case-insensitive filesystems (macOS/Windows) where it would overwrite the git-tracked "version" file (lowercase) that contains the actual version. The version file is now tracked in git and maintained through version control, so the makefile target now simply validates that the file exists rather than generating it. This fixes the issue where runpodctl would report version "1.0.0-test" instead of the correct version from the tracked version file. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…-011CUW2dr3CvFSkpAkeB9ePh fix: Remove hardcoded test version from makefile
acamq
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The makefile 'version' target was writing "1.0.0-test" to a file called "VERSION" (uppercase), which caused issues on case-insensitive filesystems (macOS/Windows) where it would overwrite the git-tracked "version" file (lowercase) that contains the actual version.
The version file is now tracked in git and maintained through version control, so the makefile target now simply validates that the file exists rather than generating it.
This fixes the issue where runpodctl would report version "1.0.0-test" instead of the correct version from the tracked version file.
runpodctl versionnow printsrunpodctl v1.14.11as intended.Built and tested on:
Ubuntu 24.04.3 LTS with Linux kernel 4.4.0, x86_64
Zorin OS 18 with Linux kernel 6.14.0-33-generic, x86_64
Windows 10 Pro 22H2 x86-64