feat: IPs and port mappings in pod get output#50
Merged
DireLines merged 4 commits intorunpod:mainfrom Apr 12, 2024
Merged
Conversation
ef0xa
reviewed
Apr 12, 2024
ef0xa
reviewed
Apr 12, 2024
ef0xa
reviewed
Apr 12, 2024
DireLines
approved these changes
Apr 12, 2024
Contributor
DireLines
left a comment
There was a problem hiding this comment.
took a while to get to this because we had to implement the same struct for our own purposes, so needed to combine your version and ours. But after checking, it'll work fine. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #39