Clean interrupted Git repacks before sticky snapshots - #48
Merged
Conversation
crohr
marked this pull request as ready for review
August 3, 2026 08:16
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c3e244ed9b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
crohr
force-pushed
the
auto/cleanup-interrupted-git-repacks
branch
from
August 3, 2026 10:02
88a6140 to
394f95c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
state.jsonwas deleted or corruptedobjects/packdirectoriesRoot cause
The Git proxy starts a background full repack after cloning a mirror. Its PID was available to the post-step only through
$RUNNER_TEMP/runs-on/git-proxy/state.json; deleting or corrupting that file made cleanup silently leave the detached proxy running. A canceled or killed repack can then leave.tmp-<pid>-pack-*ortmp_pack_*output beside the original pack, and the runner can snapshot both copies.Setup now records the PID and mirror root through GitHub's action post-state, independently of the mutable runtime file. The post-step uses that state to terminate the proxy, then removes unreferenced temporary pack files before the runner's clean unmount and snapshot.
This is stacked on #43 and targets its
feature/stickybranch. It addresses the shutdown failure reported in #43's review thread atdiscussion_r3702181299.Validation
go test ./...go test -race ./internal/gitproxy ./internal/stickydiskgo vet . ./internal/gitproxy ./internal/stickydiskupx -t main-linux-amd64 main-linux-arm64 main-windows-amd64.exemake dist