Authenticate read-only Git LFS lock requests - #51
Merged
Conversation
crohr
force-pushed
the
auto/authenticate-lfs-lock-reads
branch
from
August 3, 2026 12:42
d8bb40f to
ee2da15
Compare
crohr
marked this pull request as ready for review
August 3, 2026 12:42
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The Git proxy substituted its upstream credential only for LFS download batches. Private-repository lock reads therefore forwarded the action's opaque localhost credential to GitHub and failed authentication.
This uses an exact method-and-path allowlist for the two read-only lock operations:
GET .../info/lfs/locksPOST .../info/lfs/locks/verifyAddresses discussion_r3702181313.
Validation
go test ./...go test -race ./internal/gitproxy ./internal/stickydiskgo vet . ./internal/gitproxy ./internal/stickydiskGOOS=windows GOARCH=amd64 go test -c ./internal/gitproxyupx -t main-linux-amd64 main-linux-arm64 main-windows-amd64.exegit diff --check