Skip to content

Allow verified Windows sticky mount roots - #53

Merged
crohr merged 2 commits into
mainfrom
auto/windows-sticky-mount-root
Aug 4, 2026
Merged

Allow verified Windows sticky mount roots#53
crohr merged 2 commits into
mainfrom
auto/windows-sticky-mount-root

Conversation

@crohr

@crohr crohr commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • allow the Windows sticky root when mountvol verifies it as an active volume mount
  • keep strict link rejection for every path below the sticky root
  • add a Windows regression test and rebuild the distributed action binaries

Root cause

Windows exposes C:\\runs-on\\stickydisk as an NTFS volume-mount reparse point. The new persisted-path hardening used Lstat on the mount root and rejected that legitimate mount before creating any cache source directories.

The workflow then logged a warning, skipped cache setup, and failed because windows-cache was never created.

Impact

Windows custom sticky caches can use the verified mounted volume again without weakening protection against restored junctions or symlinks inside cache state.

Validation

  • go test ./internal/stickydisk
  • go vet ./internal/stickydisk
  • Windows test package cross-compilation with GOOS=windows GOARCH=amd64
  • rebuilt Linux amd64, Linux arm64, and Windows amd64 action binaries
  • adversarial review found no substantive correctness, security, performance, regression, or test-gap issues

@crohr
crohr force-pushed the auto/windows-sticky-mount-root branch from eae5039 to b58a350 Compare August 4, 2026 06:50
@crohr
crohr merged commit 3321413 into main Aug 4, 2026
9 checks passed
@crohr
crohr deleted the auto/windows-sticky-mount-root branch August 4, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant