Factor class VariableName out of SortedVariable #1538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
traiansf
reviewed
Feb 12, 2020
|
There are a lot fewer changes after #1537 is merged. |
virgil-serbanuta
approved these changes
Feb 12, 2020
| instance Show Representation where | ||
| showsPrec prec (Representation typeRep1 _) = | ||
| showParen (prec >= 10) | ||
| $ showString "Representation " . shows typeRep1 . showString " _" |
There was a problem hiding this comment.
I kind of agree with this, but I'm curious: why didn't you add a Show a requirement besides the Ord one in Representation's definition above, and show the hashed here? Was it to make the output of showing a simplified term manageable?
There was a problem hiding this comment.
That's exactly it: I'm not sure it would be useful to show the condition, and it would dominate the output to the point that I'm afraid it wouldn't be useful.
| from = mkRepresentation | ||
| {-# INLINE from #-} | ||
|
|
||
| fromText :: Text -> Representation |
There was a problem hiding this comment.
Do we still need this?
Store the Condition (with its variable names mapped down to Variable) instead of the unparsed Condition. Using the dynamic representation in this way is Slightly Evil, but 50% faster.
Taking both the side condition and the configuration as arguments, instead of only a set of free variables, helps ensure that the rule variables are renamed to avoid both the configuration AND the side condition.
ttuegel
force-pushed
the
refactor--VariableName
branch
from
51c59cb to
4536334
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After: #1537
This long-awaited refactoring of the
SortedVariableclass is necessary to (safely) state certain injectivity properties oftoVariable. That allows us to changeSideCondition.Representationin turn, yielding a 46% speed-up of thesum-to-nproof.See also: #1399
Fixes: #1472
Reviewer checklist
stack test --coveragestack haddock