Avoid allocation in refreshVariable #1539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttuegel
changed the title
ttuegel
force-pushed
the
feature--FreshPartialOrd
branch
from
41770aa to
005c912
Compare
2 tasks
ttuegel
force-pushed
the
feature--FreshPartialOrd
branch
from
005c912 to
ae90eb9
Compare
This was referenced Feb 13, 2020
ttuegel
force-pushed
the
feature--FreshPartialOrd
branch
2 times, most recently
from
44b7d9b to
180bedc
Compare
ana-pantilie
approved these changes
Feb 17, 2020
ttuegel
force-pushed
the
feature--FreshPartialOrd
branch
2 times, most recently
from
094eb5c to
9844526
Compare
HasCallStack adds call stack information to the assertions, which is important for diagnosing test failures.
The variables x and xSub were given the same name, but different sorts.
ttuegel
force-pushed
the
feature--FreshPartialOrd
branch
from
9844526 to
69390f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After: #1538
Fixes: #1399
Reviewer checklist
stack test --coveragestack haddock