Skip to content

Conversation

@ana-pantilie
Copy link
Contributor

@ana-pantilie ana-pantilie commented Mar 30, 2020

Needs #1772
Needs #1774

Fixes #1648

  • ==K hook is evaluated for constructor-like input only
  • adds internal simplification rules for bool and kequal
  • fixes unit tests
  • adds new integration test not-kequal (reduced example from evm-semantics)

Reviewer checklist
  • Test coverage: stack test --coverage
  • Public API documentation: stack haddock

@ttuegel
Copy link
Contributor

ttuegel commented Apr 6, 2020

We should make the new integration tests independent of the frontend, so that we do not have to wait for the frontend release to pass before we can merge this pull request. The evm-semantics regression tests in this repository do the same thing. There is a script which generates the Kore files from the K files, and we commit the Kore files into the repository. You should make a copy of that script and modify it for the new tests. For each test, the script should invoke kollect test-name kprove ... (fill in ... with the arguments to kprove). Then, you would run the script with the correct frontend version on your PATH and with KORE pointing to your clone of the Kore repository. We should also commit the K source files to the repository (so that the tests can be re-generated) but these should go in a subdirectory so that the Makefile doesn't try to run them automatically. (It will run the generated tests instead.)

@ana-pantilie ana-pantilie changed the title Concrete implementation of ==K Concrete implementation of ==K hook; internal simplification rules Apr 21, 2020
@ana-pantilie ana-pantilie requested a review from ttuegel April 28, 2020 22:30
@ana-pantilie ana-pantilie merged commit 43ca6dc into runtimeverification:master Apr 29, 2020
ttuegel added a commit to ttuegel/kore that referenced this pull request Apr 30, 2020
@ttuegel ttuegel mentioned this pull request Apr 30, 2020
2 tasks
ttuegel added a commit that referenced this pull request Apr 30, 2020
* Revert "Concrete implementation of ==K hook; internal simplification rules (#1714)"

This reverts commit 43ca6dc.

See test/itp-nth-ancestor.

* Add test/itp-nth-ancestor

* CHANGELOG.md: Remove note about KEQUAL.eq
ttuegel added a commit to ttuegel/kore that referenced this pull request Apr 30, 2020
ttuegel added a commit to ttuegel/kore that referenced this pull request Apr 30, 2020
rv-jenkins pushed a commit that referenced this pull request May 20, 2020
* Revert "CHANGELOG.md: Remove note about KEQUAL.eq"

This reverts commit 70a359c.

* Replay "Concrete implementation of ==K hook; internal simplification rules (#1714)"

This reverts commit f25abd3.

* Kore.Builtin.KEqual (unifyIfThenElse)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No branching in K-EQUAL hooks

2 participants