Not simplifier dependency inversion #1772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b4bbbd1.
ana-pantilie
commented
Apr 28, 2020
ttuegel
approved these changes
Apr 28, 2020
| {-# INLINE logWhile #-} | ||
|
|
||
| deriving instance MonadSimplify m => MonadSimplify (UnifierWithExplanation m) | ||
| instance MonadSimplify m => MonadSimplify (UnifierWithExplanation m) where |
Contributor
There was a problem hiding this comment.
Why can't we use the default implementations anymore?
Contributor
Author
There was a problem hiding this comment.
When trying to derive the implementation, the compiler error is:
Couldn't match type ‘UnifierWithExplanation m’
with ‘UnifierT (AccumT (First ReplOutput) m)’
arising from a use of ‘ghc-prim-0.5.3:GHC.Prim.coerce’
Do you know how this could be fixed? I can post the entire error if needed.
Co-Authored-By: Thomas Tuegel <ttuegel@mailbox.org>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer checklist
stack test --coveragestack haddock