Skip to content

Conversation

@emarzion
Copy link
Contributor

@emarzion emarzion commented Feb 17, 2021

Adds source location information for equation that fails the isLeftFunctionLike assertion in ignoreDefinition.


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@ttuegel ttuegel marked this pull request as ready for review February 17, 2021 22:18
@ttuegel ttuegel changed the title adding source location info for ignoreDefinition assertion Display location of rejected function equations Feb 17, 2021
@emarzion emarzion merged commit acc9463 into master Feb 17, 2021
@emarzion emarzion deleted the ignoreDef-loc branch February 17, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants