Skip to content

Display location of rejected function equations #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emarzion merged 4 commits into from
Feb 17, 2021
Merged

Display location of rejected function equations #2408

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4bbfaab
adding source location info for ignoreDefinition assertion
emarzion Feb 17, 2021
0481c83
switch branches
emarzion Feb 17, 2021
d8dfc16
Add error message for non-function-like definitions
ttuegel Feb 17, 2021
135e048
Merge branch 'master' into ignoreDef-loc
ttuegel Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions kore/src/Kore/Equation/Registry.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ import Kore.Syntax.Sentence
( SentenceAxiom (..)
)
import qualified Kore.Verified as Verified
import qualified Pretty

{- | Create a mapping from symbol identifiers to their defining axioms.

Expand Down Expand Up @@ -154,8 +155,13 @@ ignoreEquation Equation { attributes }
{- | Should we ignore the 'EqualityRule' for evaluating function definitions?
-}
ignoreDefinition :: Equation VariableName -> Bool
ignoreDefinition Equation { left } =
assert isLeftFunctionLike False
ignoreDefinition Equation { attributes, left }
| isLeftFunctionLike = False
| otherwise = (error . show . Pretty.vsep)
[ "left-hand side of equation was not function-like at:"
, Pretty.indent 4 $ Pretty.pretty sourceLocation
]
where
Attribute.Axiom { sourceLocation } = attributes
isLeftFunctionLike =
(Pattern.isFunction . Pattern.function) (extractAttributes left)