Changes to K frontend to support new C++ unparsing#1287
Conversation
| escape = false; | ||
| } | ||
| } | ||
| att = att.add("colors", colors.toString()); |
There was a problem hiding this comment.
It would be nice if these new attributes would be documented somewhere.
There was a problem hiding this comment.
Seconded. I see that color, colors, format are already documented in pending-documentation.md.
priorities, left, right are not, please add these to pending-documentation.md. I also see that bracket is folded into the paremetric productions section of pending-documentation.md, maybe it should be made into it's own section though?
I also see terminals here as an attribute and nat, but I don't think that's something we want the users setting, so maybe we shouldn't document that. If these are supposed to be user exposed, also add to pending-documentation.md. If not, then maybe we should either (i) make sure they don't exist in the attributes before adding them in, or (ii) have a check in the frontend that they do not occur.
3 participants
This is not ready to be merged yet, but feel free to review it as a companion to runtimeverification/llvm-backend#334.