Check parameters on attributes#3579
Conversation
gtrepta
requested review from
Robertorosmaninho,
Scott-Guest,
dwightguth,
ehildenb and
radumereuta
radumereuta
left a comment
radumereuta
left a comment
There was a problem hiding this comment.
One minor comment.
You can automerge once you fix that.
dwightguth
left a comment
dwightguth
left a comment
There was a problem hiding this comment.
Looks good but I see a couple things that look like they might be copy paste errors and I just want to clarify.
| final val KORE = Key("kore", KeyType.BuiltIn, KeyParameter.Forbidden) | ||
| final val LABEL = Key("label", KeyType.BuiltIn, KeyParameter.Required) | ||
| final val LATEX = Key("latex", KeyType.BuiltIn, KeyParameter.Required) | ||
| final val LEFT = Key("left", KeyType.BuiltIn, KeyParameter.Optional) |
There was a problem hiding this comment.
This one is forbidden, right?
There was a problem hiding this comment.
Thank you for bringing these up, I forgot about them. I set some of these to Optional because they were being generated by the compiler in a way that deviates from our discussions. For the left/right attributes, ModuleToKORE is making them with values:
k/kernel/src/main/java/org/kframework/backend/kore/ModuleToKORE.java
Lines 1606 to 1607 in a863a1e
| final val PUBLIC = Key("public", KeyType.BuiltIn, KeyParameter.Forbidden) | ||
| final val RESULT = Key("result", KeyType.BuiltIn, KeyParameter.Required) | ||
| final val RETURNS_UNIT = Key("returnsUnit", KeyType.BuiltIn, KeyParameter.Forbidden) | ||
| final val RIGHT = Key("right", KeyType.BuiltIn, KeyParameter.Optional) |
|
@dwightguth Addressing these will probably require separate issues for them. |
4 participants
Makes progress on #3481