imports FOO.bar#2144
Merged
rv-jenkins merged 23 commits intomasterfrom Aug 23, 2021
Merged
Conversation
added 12 commits
August 18, 2021 14:09
radumereuta
suggested changes
Aug 19, 2021
Contributor
radumereuta
left a comment
radumereuta
left a comment
There was a problem hiding this comment.
This could use some tests.
Some JUnit tests in OuterParsingTests for the new syntax and two tests in
regression-new/checks one with an error, and one that passes.
I will look into the semantics of this PR tomorrow when I have more energy.
Contributor
|
More tests, please, and documentation too. |
Contributor
|
This is part of #2115 |
radumereuta
suggested changes
Aug 23, 2021
Contributor
radumereuta
left a comment
radumereuta
left a comment
There was a problem hiding this comment.
Overall pretty good. Just the two small changes.
radumereuta
approved these changes
Aug 23, 2021
radumereuta
added a commit
that referenced
this pull request
Sep 27, 2021
rv-jenkins
pushed a commit
that referenced
this pull request
Sep 27, 2021
dwightguth
pushed a commit
that referenced
this pull request
Nov 1, 2021
* fix import toString * kil for partial import * kore class for partial import * partial import toString * partial import FlatImport * fix Import constructors * scala java converters for Option/Optional * fix import constructors * fix json parser/unparser * fix kiltokore * fix outer parser * implement signature function for partial imports * fix ToJson * break long lines * add failing test * add passing test * add outer parsing test * documentation * fix whitespace * fix typo * More elaborate failing test. Co-authored-by: Radu Mereuta <headness13@gmail.com> Co-authored-by: rv-jenkins <admin@runtimeverification.com>
dwightguth
pushed a commit
that referenced
this pull request
Nov 3, 2021
* `imports FOO.bar` (#2144) * fix import toString * kil for partial import * kore class for partial import * partial import toString * partial import FlatImport * fix Import constructors * scala java converters for Option/Optional * fix import constructors * fix json parser/unparser * fix kiltokore * fix outer parser * implement signature function for partial imports * fix ToJson * break long lines * add failing test * add passing test * add outer parsing test * documentation * fix whitespace * fix typo * More elaborate failing test. Co-authored-by: Radu Mereuta <headness13@gmail.com> Co-authored-by: rv-jenkins <admin@runtimeverification.com> * fix OOM by not storing signature as lazy val * fix test output * Fix long lines Co-authored-by: Radu Mereuta <headness13@gmail.com> Co-authored-by: rv-jenkins <admin@runtimeverification.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not contain any syntax for renaming yet; I am simply focusing on the task of importing specific syntax by its tag.