imports FOO.bar with fixed OOM#2292
Merged
dwightguth merged 7 commits intomasterfrom Nov 3, 2021
Merged
Conversation
* fix import toString * kil for partial import * kore class for partial import * partial import toString * partial import FlatImport * fix Import constructors * scala java converters for Option/Optional * fix import constructors * fix json parser/unparser * fix kiltokore * fix outer parser * implement signature function for partial imports * fix ToJson * break long lines * add failing test * add passing test * add outer parsing test * documentation * fix whitespace * fix typo * More elaborate failing test. Co-authored-by: Radu Mereuta <headness13@gmail.com> Co-authored-by: rv-jenkins <admin@runtimeverification.com>
radumereuta
approved these changes
Nov 1, 2021
Contributor
radumereuta
left a comment
radumereuta
left a comment
There was a problem hiding this comment.
I've tested the changes and they seem to have fixed the problem.
Just one aesthetic change. One of the lines is too long.
Feel free to merge after that.
7 tasks
radumereuta
added a commit
that referenced
this pull request
Dec 9, 2021
This reverts commit 41f2e80.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit is a cherry pick of #2144 and probably doesn't need to be reviewed again.