Fix for --version when .git is missing#2454
Merged
rv-jenkins merged 1 commit intomasterfrom Feb 24, 2022
Merged
Conversation
Contributor
|
What is the output of |
Contributor
Author
|
The format isn't new - this PR just restores what used to happen. $ kompile --version
K version: 5.2.0
Build date: Thu Feb 24 08:59:45 CST 2022 |
radumereuta
approved these changes
Feb 24, 2022
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure that the version string script outputs an empty string if git isn't installed, or there is no git directory alongside the source code. Doing so means that the package version file gets used instead when building release packages (
dpkgorbrew).