Adding arguments to kast flags#3642
Merged
rv-jenkins merged 2 commits intodevelopfrom Sep 14, 2023
Merged
Conversation
radumereuta
approved these changes
Sep 14, 2023
Contributor
radumereuta
left a comment
There was a problem hiding this comment.
PR lgtm but there are some failing tests
6 tasks
| private ColorSetting color; | ||
| @Parameter(names = "--color", description = "Use colors in output.", descriptionKey = "mode", | ||
| converter=ColorModeConverter.class) | ||
| private ColorSetting color = ColorSetting.ON; |
Collaborator
Author
There was a problem hiding this comment.
That's funny, it seems that the error is from this modification. The help message says that the default is color=ON, but when I really implemented it, it raised the error on max-fail-spec.k
Collaborator
Author
There was a problem hiding this comment.
Notice that the output also changed depending on --color ON and --color OFF:
With color:
<T>
<k>
.
</k>
<state>
a |-> A:Int
b |-> B:Int
max |-> B:Int
</state>
</T>
#And
#Not ( {
A
#Equals
B
}
#And
{
true
#Equals
B >=Int B
} )
#And
{
true
#Equals
A <=Int B
}
Without color:
#Not ( {
A
#Equals
B
}
#And
{
true
#Equals
B >=Int B
} )
#And
<T>
<k>
.
</k>
<state>
a |-> A:Int
b |-> B:Int
max |-> B:Int
</state>
</T>
#And
{
true
#Equals
A
Collaborator
Author
There was a problem hiding this comment.
I've just filled an issue to track it: #3643
rv-jenkins
pushed a commit
that referenced
this pull request
Sep 15, 2023
Follow up of #3619, #3638, and #3642! This PR enhances the usability of `kprove --help` and `kprove --help-hidden` by providing flag descriptors to help the user understand when an argument needs to be provided to the flag. Ex.: Before ``` Usage: kprove [options] <file> Options: --branching-allowed Number of branching events allowed before a forcible stop. Default: 2147483647 ``` Now: ``` Usage: kprove [options] <file> Options: --branching-allowed <value> Number of branching events allowed before a forcible stop. Default: 2147483647 ``` Among others, this PR introduces the following arguments to the respective parameters: parameter | argument -- | -- --branching-allowed | \<number> --claims | \<labels> --color | \<mode> --debug-script | \<file> --default-claim-type | \<type> --definition | \<path> --depth | \<number> --emit-json-spec | \<file> --exclude | \<labels> --output, -o | \<mode> --output-file | \<file> --output-flatten | \<KLabels> --output-omit | \<KLabels> --output-tokast | \<KLabels> --output-tokenize | \<KLabels> --spec-module, -sm | \<name> --trusted | \<labels> --haskell-backend-command | \<command> --haskell-backend-home | \<directory> --smt-timeout | \<milliseconds>
5 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #3619 and #3638!
This PR enhances the usability of
kast --helpandkast --help-hiddenby providing flag descriptors to help the user understand when an argument needs to be provided to the flag.Ex.:
Before
Now:
Among others, this PR introduces the following arguments to the respective parameters: