Adding arguments to kprove flags#3648
Merged
rv-jenkins merged 4 commits intodevelopfrom Sep 15, 2023
Merged
Conversation
radumereuta
reviewed
Sep 15, 2023
Contributor
radumereuta
left a comment
There was a problem hiding this comment.
A few suggestions.
Ping me again when you answered all of them and tests passed.
Collaborator
Author
|
@radumereuta, I've implemented your comments! However, I would appreciate a new round on the comment I didn't mark resolved! |
radumereuta
reviewed
Sep 15, 2023
5 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #3619, #3638, and #3642!
This PR enhances the usability of
kprove --helpandkprove --help-hiddenby providing flag descriptors to help the user understand when an argument needs to be provided to the flag.Ex.:
Before
Now:
Among others, this PR introduces the following arguments to the respective parameters: