Conversation
rusq
commented
Jul 13, 2026
rusq
commented
Owner
- update copilot mcp file loc
- add codex and fix copilot mcp.json location
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates Slackdump’s MCP project scaffolding to support a new Codex layout and changes the Copilot scaffold to place the MCP config at the project root (.mcp.json) instead of under .vscode/, aligning documentation and tests with the new layout outputs.
Changes:
- Add a new
codexMCP project layout that generates.codex/config.tomland installs skills under.agents/skills/. - Move the Copilot MCP config output to root
.mcp.jsonand update the JSON schema key tomcpServers. - Update documentation, agent guide, tests, and
.gitignoreexceptions to keep new embedded layout assets tracked.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents the new codex scaffold option alongside existing MCP layouts. |
| cmd/slackdump/internal/mcp/mcp.go | Adds codex to the supported layout list used by -new. |
| cmd/slackdump/internal/mcp/mcp_test.go | Consolidates layout scaffolding tests and adds coverage for the new codex outputs. |
| cmd/slackdump/internal/mcp/assets/mcp.md | Updates MCP help docs for the Copilot .mcp.json location/schema and documents the new codex layout. |
| cmd/slackdump/internal/mcp/assets/layouts/copilot/layout.json | Switches Copilot scaffold to copy root .mcp.json instead of .vscode/mcp.json. |
| cmd/slackdump/internal/mcp/assets/layouts/copilot/.mcp.json | Updates Copilot template config to mcpServers and root-file format. |
| cmd/slackdump/internal/mcp/assets/layouts/codex/layout.json | Introduces the new Codex layout manifest (files + installed skills). |
| cmd/slackdump/internal/mcp/assets/layouts/codex/.codex/config.toml | Adds the Codex MCP server configuration template. |
| AGENTS.md | Updates the repository agent guide to include codex as a supported MCP scaffold layout. |
| .gitignore | Ensures embedded layout .json / .toml assets under cmd/.../layouts/ are not ignored. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes the Windows CI failure in Test_runMCPNewProject/codex: autocrlf converted assets/layouts/codex/.codex/config.toml to CRLF at checkout, which go:embed then baked into the binary. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.