Remove mutable api - #215
Merged
ChayimFriedman2 merged 5 commits intoAug 2, 2026
Merged
Conversation
bit-aloo
force-pushed
the
2026-07-31-remove-mutable-api
branch
from
July 31, 2026 06:14
2b6c979 to
42b61b1
Compare
Member
Author
ChayimFriedman2
approved these changes
Aug 2, 2026
| } | ||
| ptr::NonNull::new_unchecked(Box::into_raw(Box::new(res))) | ||
| } | ||
| ptr::NonNull::from(Box::leak(Box::new(res))) |
Contributor
There was a problem hiding this comment.
Suggested change
| ptr::NonNull::from(Box::leak(Box::new(res))) | |
| ptr::NonNull::new_unchecked(Box::into_raw(Box::new(res))) |
It is not clear whether it's okay to call Box::from_raw(Box::leak(...)).
Member
Author
There was a problem hiding this comment.
hmm.. reverted back. Though I wanted to remove that unsafe, but ok.
bit-aloo
force-pushed
the
2026-07-31-remove-mutable-api
branch
from
August 2, 2026 03:17
42b61b1 to
cfe7ef4
Compare
Contributor
|
Oh, we don't have merge queue for rowan? CC @Veykril. |
Contributor
|
Oops you filled the PR against the wrong branch. I'll fix this. |
Contributor
|
I did a force-push to master, hopefully that's not a problem since rowan is not that forked and history is messed up anyway. |
Contributor
|
Okay published 0.17.0. |
Member
Author
We removed all of v0.16 history. 😢 |
Contributor
|
Restored it under https://github.com/rust-analyzer/rowan/tree/v0.16, which is a copy of the old |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to make a small adaptation for rust-analyzer, though it should be pretty minor.