CI: `Verify` job does not fail on error

[tcharding]

We have a Verify job but errors from running cd verify && cargo run all do not cause the job to fail. What this means is that over the last few months while @jamillambert has been working the docs (eg types/src/v23/mod.rs) have become the Single Source Of True (SSOT) instead of the verify/src/method/v23.rs file as was once intended. This makes the verify script broken, currently giving a bunch of false positives.

The question now is: Do we want to keep the verify tool? This would require going over all the outputs and checking if they are false positives. Or just trusting the docs, which is kind of what I would do if I just spent months doing them all. Which begs the initial question?

[tcharding]

I checked all the errors for v23 to get a feel for this problem and found 4 out of 5 to be false positives (one caused by a typo), and found one bug in verify that was causing the 5th.

[jamillambert]

I like the idea of having a second check that the models or returns weren't unintentionally changed. Any change to the verify code suggests that you should have a second look that the model etc. was dropped for a valid reason.

I fixed all failures, the issues were all in verify not types, and I made it so that the CI job fails if there are errors in #352.

[tcharding]

Legend.