Fix verify #352
Merged
Fix verify #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamillambert
force-pushed
the
0809-verify-fix
branch
2 times, most recently
from
275b042 to
a8a2291
Compare
During the updating of the RPCs some of them changed from having a model to not or vice versa. There is also one typo and a duplicate entry for `enumeratesigners` which was added to `signer` and not removed from `wallet`. Fix the tags in verify to match the correct RPC method definitions.
There were false positives in verify when the RPC name was a substring of another identifier. Change the regex to match whole words.
jamillambert
force-pushed
the
0809-verify-fix
branch
from
a8a2291 to
2a6eec7
Compare
tcharding
approved these changes
Sep 9, 2025
Member
|
Nice one fella. |
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
2a6eec72683a971ae91d6df7f6eebeb84039be04 Make verfiy fail on error (Jamil Lambert, PhD)
31382bf83826751418176c8350b0f35751e62f2e Verify search for whole word (Jamil Lambert, PhD)
e2c78e4b7cf87e1f82dbe40df6b32441c34e900a Fix verify RPC method tags (Jamil Lambert, PhD)
Pull request description:
#351 described the problem
- During the updating of the RPCs some of them changed from having a
model to not or vice versa. There is one typo. There is also a duplicate entry for `enumeratesigners` which was added to `signer` and not removed from `wallet`.
- Fix the tags in `verify` to match the correct RPC method definitions.
- There were false positives in verify when the RPC name was a substring
of another identifier.
- Change the regex to match whole words.
- `verify` does not fail when there are detected problems, it prints
`Correct ✓` and continues.
- Change the tool so that it prints `Incorrect ✗` if there are
inconsistencies.
- Run all tests to the end and then if there were any errors, return a
non-zero exit code.
- Change `verify_correct_methods` to return a `Result<()>` instead of `Result<(bool)>` to match the other functions.
Closes #351
ACKs for top commit:
tcharding:
ACK 2a6eec72683a971ae91d6df7f6eebeb84039be04
Tree-SHA512: a3c43af866f02fd7ec18ab608935fdd4e05cd9cec4e91cddacf6c4574791531aae0394db194c5c31e869402dd2a049164b22b24dcb6e62e582255a3184182d1d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#351 described the problem
model to not or vice versa. There is one typo. There is also a duplicate entry for
enumeratesignerswhich was added tosignerand not removed fromwallet.verifyto match the correct RPC method definitions.of another identifier.
verifydoes not fail when there are detected problems, it printsCorrect ✓and continues.Incorrect ✗if there areinconsistencies.
non-zero exit code.
verify_correct_methodsto return aResult<()>instead ofResult<(bool)>to match the other functions.Closes #351