client: rename all macros to have an underscore between words #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
approved these changes
May 29, 2025
|
Hot. I put in on draft because you mention it in the PR description. But I reviewed and acked anyway. |
|
When you rebase note #210 |
To make all version modules the same format move the modules from the crate root to their own subdirectory.
To match the naming convention used in the rest of the repo add an underscore between the words in the macro names. The new names are all taken from the lists in `verify/src/method/`.
jamillambert
force-pushed
the
0528-macro-names
branch
from
d48920a to
1251249
Compare
|
I redid the commits rather than rebase, since it was easier to rerun the rename function I wrote than deal with all the merge conflicts. But the rename function is unchanged so the result should be unchanged except for the additional |
Thanks, I meant to put it in as draft, but apparently didn't. |
tcharding
approved these changes
May 29, 2025
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
…nderscore between words
1251249468e1671fb32e8ce155b8c9b65b36d309 Rename all macros to have underscores (Jamil Lambert, PhD)
107e2fab0fefd8318cd4e385535670e194e9ad40 Move client modules into subfolders (Jamil Lambert, PhD)
Pull request description:
To match the naming convention used in the rest of the repo add an underscore between the words in the macro names.
The new names are all taken from the lists in `verify/src/method/` using regex to find a match for the first entry in the list and replace it with the last entry in the list.
The version modules for versions 20, 24, 25 and 27 were all moved from the crate root into their own subdirectory to match the structure of the other versions.
ACKs for top commit:
tcharding:
ACK 1251249468e1671fb32e8ce155b8c9b65b36d309
Tree-SHA512: ec4a40fd2de413d5997cd7fdf9c2e007aa621eeb80262c3ebebf7d7ffce5b823fd1866a6370829411c78da0362deafd67de34be135a4fb1987312c95c5725b18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match the naming convention used in the rest of the repo add an underscore between the words in the macro names.
The new names are all taken from the lists in
verify/src/method/using regex to find a match for the first entry in the list and replace it with the last entry in the list.The version modules for versions 20, 24, 25 and 27 were all moved from the crate root into their own subdirectory to match the structure of the other versions.