Implement disconnectnode method and test #210
Conversation
GideonBature
force-pushed
the
disconnectnode
branch
from
49020fd to
e5e52a0
Compare
There was a problem hiding this comment.
Looks good except the test name. Perhaps since you are using the same PR description for each of these PRs you do we could make it more terse and more meaningful. Something like
'JSONRPC method foo does not return anything, we would like to test this in case a later version of Core changes this behaviour. Add a function to the client that errors if anything but null is returned then add an integration test that calls this new function.'
GideonBature
force-pushed
the
disconnectnode
branch
from
e5e52a0 to
359ac38
Compare
This is better... Will adopt this. Thank you! |
359ac383f28c579d5ed79ded0bba0a38cb765f0c Implement disconnectnode method and test (GideonBature) Pull request description: Going by the conversations with tcharding for PR [#116 ](rust-bitcoin/corepc#116) on implementing one method at a time for easier review: This is the disconnectnode method which is a specific type that returns a (json null). Once this is approved, I’ll proceed with the next one. ACKs for top commit: tcharding: ACK 359ac383f28c579d5ed79ded0bba0a38cb765f0c Tree-SHA512: 3b16431e732e81edea1f290cf6436ae5ad0e72a591546b09e69eb47092c95ccef5e07be8908f20d32fb87a77cf623caf07eee0e96b96bc2fab7240af23e4286a
2 participants
The JSON-RPC method
disconnectnodedoes not return anything. We want to test this to catch any changes in behavior in future Core versions.This PR adds a client function that errors if the return value is anything other than
null, along with an integration test that calls this function.Ref: #116