Address all TODO in v27 #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
reviewed
Aug 1, 2025
types/src/model/network.rs
Outdated
| /// The services offered. | ||
| pub services: u64, | ||
| /// The address of the node. | ||
| pub address: Address<NetworkUnchecked>, |
Member
There was a problem hiding this comment.
Ha, we botched this when added in #191. I wrote some comments on that issue.
jamillambert
force-pushed
the
0801-v27-TODO
branch
from
108e2a1 to
cf4694c
Compare
Merged
tcharding
previously approved these changes
Aug 5, 2025
jamillambert
dismissed
tcharding’s stale review
The merge-base changed after approval.
tcharding
previously approved these changes
Aug 5, 2025
Member
|
Trivial rebase, no conflicts. |
jamillambert
dismissed
tcharding’s stale review
The merge-base changed after approval.
The return fields changed in v27. Redefine the type in v27, update reexports.
Reordering of reexports only.
jamillambert
force-pushed
the
0801-v27-TODO
branch
from
cf4694c to
93ed34f
Compare
Collaborator
Author
|
Rebased, no changes |
|
ACK 93ed34f |
tcharding
approved these changes
Aug 5, 2025
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
93ed34fc0dbc437685ec797f1437112d49589f21 Run the formatter (Jamil Lambert, PhD)
0132f7a7617009ad2cc61a1ac7007eb6ab6adbee Redefine getnodeaddresses in v27 (Jamil Lambert, PhD)
Pull request description:
Go through all the TODO in the v26 types table.
- Redefine `getnodeaddresses`: There were return field changes in v27. Redefine the struct and update the reexports. Update the types tables.
- Run the formatter: Done separately to make it easier to see the changes in patch 1.
DRAFT because on top of #321. This PR is the last 2 patches.
ACKs for top commit:
jrakibi:
ACK 93ed34fc0dbc437685ec797f1437112d49589f21
tcharding:
ACK 93ed34fc0dbc437685ec797f1437112d49589f21
Tree-SHA512: 8cd4ca5ae831bb0ff65a00194149b31cf543fbbc23acd29801462bb16b7200a020df51522e0aa787b1da927e3b6e1e33743c4b904b994a64b0ad802ade2a7882
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go through all the TODO in the v26 types table.
getnodeaddresses: There were return field changes in v27. Redefine the struct and update the reexports. Update the types tables.DRAFT because on top of #321. This PR is the last 2 patches.