Remove getnodeaddresses model
#321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getnodeaddresses returns a node Address not a bitcoin Address. Remove the model. Update the test to create 3 nodes and remove the model. Update the types table and verify.
jamillambert
force-pushed
the
0804-getnodeaddresses
branch
from
09c470c to
da947f1
Compare
Merged
tcharding
approved these changes
Aug 5, 2025
tcharding
added a commit
that referenced
this pull request
Aug 5, 2025
93ed34f Run the formatter (Jamil Lambert, PhD) 0132f7a Redefine getnodeaddresses in v27 (Jamil Lambert, PhD) Pull request description: Go through all the TODO in the v26 types table. - Redefine `getnodeaddresses`: There were return field changes in v27. Redefine the struct and update the reexports. Update the types tables. - Run the formatter: Done separately to make it easier to see the changes in patch 1. DRAFT because on top of #321. This PR is the last 2 patches. ACKs for top commit: jrakibi: ACK 93ed34f tcharding: ACK 93ed34f Tree-SHA512: 8cd4ca5ae831bb0ff65a00194149b31cf543fbbc23acd29801462bb16b7200a020df51522e0aa787b1da927e3b6e1e33743c4b904b994a64b0ad802ade2a7882
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
da947f10a10db6ae5dbcb938dd9eef08c75b77a5 Remove getnodeaddresses model (Jamil Lambert, PhD)
Pull request description:
`getnodeaddresses` returns a node address not a bitcoin address.
Remove the model.
Update the test to create 3 nodes and remove the model. The RPC still returns an empty list with 3 nodes see Issue #320.
ACKs for top commit:
tcharding:
ACK da947f10a10db6ae5dbcb938dd9eef08c75b77a5
Tree-SHA512: 5d960d19726745d8136557dae271ae8810c4bcc89ec72eeef16e80811bdbbf45f51497670367ab00166403a9f8a5f9561a210944d1c76b84ab69f21e97265389
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getnodeaddressesreturns a node address not a bitcoin address.Remove the model.
Update the test to create 3 nodes and remove the model. The RPC still returns an empty list with 3 nodes see Issue #320.