Type alias SignRawTransaction
#364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamillambert
force-pushed
the
0912-type-alias
branch
from
226cf3c to
438a06f
Compare
Both `signrawtransactionwithkey` and `signrawtransactionwithwallet` use the type `SignRawTransaction` in types and model. Add aliases for these two RPC methods and a note in the docs explaining why.
Both `signrawtransactionwithkey` and `signrawtransactionwithwallet` use the type `SignRawTransaction` in types and model. These now have their own type aliases. Use the aliases in client and integration_test.
jamillambert
force-pushed
the
0912-type-alias
branch
from
438a06f to
5b3fbcd
Compare
tcharding
approved these changes
Sep 14, 2025
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
5b3fbcd455ed31c656c6241132161a919cfec113 Run the formatter (Jamil Lambert, PhD)
c84e07d322cb39b56dbc9aa13d9f77ef8c2c814d Use the type alias of SignRawTransaction (Jamil Lambert, PhD)
e0f1311ee5ac415fc1a6a9011f2907ee40953460 Type alias SignRawTransaction (Jamil Lambert, PhD)
Pull request description:
Both `signrawtransactionwithkey` and `signrawtransactionwithwallet` use the type `SignRawTransaction` in types and model. But the policy is to have a type for all RPCs with the same name, this makes everything uniform and easier to use without having to search for the correct type.
- Add aliases for these two RPC methods and a note in the docs explaining why.
- Use the new aliases in the tests.
- Run the formatter. Reordering reexports only.
Closes #357
ACKs for top commit:
tcharding:
ACK 5b3fbcd455ed31c656c6241132161a919cfec113
Tree-SHA512: 9d8f7b29946c9fcbf91c064fc7ee0e96e2439b9c93b68b2c77b855984eead90501ae838ca61c8d10244e0cc5f580d305a5407ffc2d4f9aab91a3445cd3041d15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
signrawtransactionwithkeyandsignrawtransactionwithwalletuse the typeSignRawTransactionin types and model. But the policy is to have a type for all RPCs with the same name, this makes everything uniform and easier to use without having to search for the correct type.Closes #357