Update readme #37
Merged
Update readme #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 6092f89 renamed the `bitcoind` directory to be `node` and the `BitcoinD` type to `Node`, but the examples in the readme did not reflect the changes.
tcharding
approved these changes
Dec 19, 2024
Member
|
Legend! Thanks for the PR. |
tcharding
reviewed
Dec 19, 2024
|
|
||
| Startup options could be configured via the [`Conf`] struct using [`BitcoinD::with_conf`] or | ||
| [`BitcoinD::from_downloaded_with_conf`] | ||
| Startup options could be configured via the [`Conf`] struct using [`Node::with_conf`] or |
Member
There was a problem hiding this comment.
Suggested change
| Startup options could be configured via the [`Conf`] struct using [`Node::with_conf`] or | |
| Startup options could be configured via the [`Conf`] struct using [`Node::with_conf`] or |
Member
|
Woops, I got trigger happy and merged while the trailing whitespace was there - my bad. |
Member
|
Fixed in #39. |
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
6268b6becda1d95d55b57fea0536d6c5f809db39 Update readme (Edil Medeiros)
Pull request description:
Commit 6092f8944cd565d3ee5523e7e7d2910021d49979 renamed the `bitcoind` directory to be `node` and the `BitcoinD` type to `Node`, but the examples in the readme did not reflect the changes.
ACKs for top commit:
tcharding:
ACK 6268b6becda1d95d55b57fea0536d6c5f809db39
Tree-SHA512: 311f42708a5a87136e77f5f01b03db5010ca9cd2ccb5ed0517986847037d320f0236a6ea1698f85d63df81ee49856eb9ac67c35dbf3e8badf5965edceb123de2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 6092f89 renamed the
bitcoinddirectory to benodeand theBitcoinDtype toNode, but the examples in the readme did not reflect the changes.