fix(types): v24+ should use correct GetRawMempoolVerbose #381
+45
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
tcharding
approved these changes
Oct 9, 2025
Member
|
To get around diffs like this, in this project what we have come up with is any time the re-exports get patched we put the formatting change in a separate patch. Not to worry, with you explanation I worked it out. Thanks man, and yes I'd call this a bug so we can do 0.10.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some leftovers from the recent fixes.
Sorry that I had not catch this earlier 😢
@tcharding this should be a patch release 0.10.1, what you think?
EDIT: The diff is bad but what is doing is removing the
v17::GetRawMempoolVerboseand adding to thev24::GetRawMempoolVerbosein allv25-v29versions.